Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993233002: Cleanup: shared isolate (Closed)

Created:
4 years, 7 months ago by Mircea Trofin
Modified:
4 years, 7 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup: shared isolate BUG= Committed: https://crrev.com/ec2c5a037a42ed9984c74301d503108b0387231b Cr-Commit-Position: refs/heads/master@{#36394}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/wasm/wasm-module.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
4 years, 7 months ago (2016-05-19 19:09:21 UTC) #3
titzer
On 2016/05/19 19:09:21, Mircea Trofin wrote: lgtm
4 years, 7 months ago (2016-05-20 07:52:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993233002/20001
4 years, 7 months ago (2016-05-20 08:02:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 08:04:51 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 08:05:50 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ec2c5a037a42ed9984c74301d503108b0387231b
Cr-Commit-Position: refs/heads/master@{#36394}

Powered by Google App Engine
This is Rietveld 408576698