Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1993213003: Make GrAtlasTextBlob::run own effects it points to. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrAtlasTextBlob::run own effects it points to. BUG=chromium:608566 Currently the run has bare pointers and the effects can be destroyed while a run is pointing at them. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993213003 Committed: https://skia.googlesource.com/skia/+/8b6fa5e8a9016ebbf3a03009abc3845b71452550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M src/gpu/text/GrAtlasTextBlob.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
bsalomon
I looked at making SkScalerContextEffects us sk_sp and move it into SkScalerContext but it was ...
4 years, 7 months ago (2016-05-19 22:31:26 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993213003/1
4 years, 7 months ago (2016-05-19 22:31:50 UTC) #6
bungeman-skia
lgtm
4 years, 7 months ago (2016-05-19 22:44:27 UTC) #7
bungeman-skia
The description should probably point to the BUG.
4 years, 7 months ago (2016-05-19 22:45:01 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 22:51:41 UTC) #10
bsalomon
On 2016/05/19 22:45:01, bungeman-skia wrote: > The description should probably point to the BUG. Yep, ...
4 years, 7 months ago (2016-05-19 23:22:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993213003/1
4 years, 7 months ago (2016-05-19 23:22:53 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:23:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8b6fa5e8a9016ebbf3a03009abc3845b71452550

Powered by Google App Engine
This is Rietveld 408576698