Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1993163003: [Editing][Stability] Recanonicalize m_originalbase in FrameSelection (Closed)

Created:
4 years, 7 months ago by yoichio
Modified:
4 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][Stability] Recanonicalize m_originalbase in FrameSelection The crash issue 562339 is caused in computeInlineBoxPositionTemplate called in the RenderPosition constructor. The root issue is FrameSelection::setNonDirectionalSelectionIfNeededAlgorithm uses m_originalBase as up-to-date. m_originBase is used only in the function. However, there can be layout by next call. Thus this CL recanonicalizes m_originalBase. This CL also fix the issue m_originalBase/inFlatTree are leaked. BUG=562339, 593592 TEST=LayoutTests/editing/selection/mouse/drag_selection_update_crash.html Committed: https://crrev.com/9188249cc0a957865cc7aa592f6477b38cbb7f9a Cr-Commit-Position: refs/heads/master@{#395001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/editing/selection/mouse/drag_selection_update_crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 3 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
yoichio
4 years, 7 months ago (2016-05-19 09:00:12 UTC) #3
yosin_UTC9
lgtm
4 years, 7 months ago (2016-05-20 04:26:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993163003/1
4 years, 7 months ago (2016-05-20 04:26:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 04:45:27 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 04:46:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9188249cc0a957865cc7aa592f6477b38cbb7f9a
Cr-Commit-Position: refs/heads/master@{#395001}

Powered by Google App Engine
This is Rietveld 408576698