Chromium Code Reviews
Description[Editing][Stability] Recanonicalize m_originalbase in FrameSelection
The crash issue 562339 is caused in computeInlineBoxPositionTemplate called in the
RenderPosition constructor.
The root issue is FrameSelection::setNonDirectionalSelectionIfNeededAlgorithm
uses m_originalBase as up-to-date.
m_originBase is used only in the function.
However, there can be layout by next call.
Thus this CL recanonicalizes m_originalBase.
This CL also fix the issue m_originalBase/inFlatTree are leaked.
BUG=562339, 593592
TEST=LayoutTests/editing/selection/mouse/drag_selection_update_crash.html
Committed: https://crrev.com/9188249cc0a957865cc7aa592f6477b38cbb7f9a
Cr-Commit-Position: refs/heads/master@{#395001}
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||