Issue 19931003: Update freetype DEPS to version 2.5 with PNG encoded color bitmap glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19931003: Update freetype DEPS to version 2.5 with PNG encoded color bitmap glyphs (Closed)

Created:
7 years, 5 months ago by djsollen

Modified:
7 years, 5 months ago

Reviewers:
bungeman-skia, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Update freetype DEPS to version 2.5 with PNG encoded color bitmap glyphs R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=10259

Patch Set 1 #

Total comments: 4

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+844 lines, -1 line)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/freetype.gyp	View	3 chunks	+10 lines, -0 lines	1 comment	Download
A	third_party/freetype/config/ftoption.h	View	1 chunk	+833 lines, -0 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

This change itself lgtm, with several comments on direction. https://codereview.chromium.org/19931003/diff/1/gyp/freetype.gyp File gyp/freetype.gyp (right): https://codereview.chromium.org/19931003/diff/1/gyp/freetype.gyp#newcode34 gyp/freetype.gyp:34: ...

7 years, 5 months ago (2013-07-22 20:42:12 UTC) #2

djsollen

7 years, 5 months ago (2013-07-23 12:22:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10259 (presubmit successful).

Expand Messages | Collapse Messages