Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1993063002: S390: Added 56 new instructions to the simulator EVALUATE code. (Closed)

Created:
4 years, 7 months ago by bcleung
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Added 56 new instructions to the simulator EVALUATE code. R=joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Committed: https://crrev.com/e0e10712ec0d0e2610241ba88dfc995c1aa93c3a Cr-Commit-Position: refs/heads/master@{#36375}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed DCHECKs prohibiting generation of AGF, SGF on 31-bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+776 lines, -53 lines) Patch
M src/s390/simulator-s390.cc View 1 16 chunks +776 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JoranSiu
lgtm otherwise. https://codereview.chromium.org/1993063002/diff/1/src/s390/simulator-s390.cc File src/s390/simulator-s390.cc (right): https://codereview.chromium.org/1993063002/diff/1/src/s390/simulator-s390.cc#newcode9203 src/s390/simulator-s390.cc:9203: DCHECK(false); I don't think we need these ...
4 years, 7 months ago (2016-05-18 23:06:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063002/20001
4 years, 7 months ago (2016-05-19 16:58:19 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 17:26:54 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:28:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0e10712ec0d0e2610241ba88dfc995c1aa93c3a
Cr-Commit-Position: refs/heads/master@{#36375}

Powered by Google App Engine
This is Rietveld 408576698