Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993033003: Ship "Response construction with ReadableStream". (Closed)

Created:
4 years, 7 months ago by yhirano
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, domenic, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship "Response construction with ReadableStream". Intent-To-Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0S-jPuCy8ws BUG=564479, 596832 Committed: https://crrev.com/e0cb6a355deab56251cea1ac5b2bcc4b605c76e2 Cr-Commit-Position: refs/heads/master@{#395223}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -93 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -3 lines 0 comments Download
M build_overrides/v8.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/streams/README.md View 1 2 3 4 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableByteStream.idl View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/streams/ReadableStreamTempStub.js View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
yhirano
We haven't had enough LGTMs on the intent-to-ship thread yet, but can you take a ...
4 years, 7 months ago (2016-05-19 05:55:57 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/1993033003/diff/20001/third_party/WebKit/Source/core/streams/README.md File third_party/WebKit/Source/core/streams/README.md (right): https://codereview.chromium.org/1993033003/diff/20001/third_party/WebKit/Source/core/streams/README.md#newcode33 third_party/WebKit/Source/core/streams/README.md:33: work to build Fetch response body streams on ...
4 years, 7 months ago (2016-05-19 06:44:40 UTC) #3
yhirano
https://codereview.chromium.org/1993033003/diff/20001/third_party/WebKit/Source/core/streams/README.md File third_party/WebKit/Source/core/streams/README.md (right): https://codereview.chromium.org/1993033003/diff/20001/third_party/WebKit/Source/core/streams/README.md#newcode33 third_party/WebKit/Source/core/streams/README.md:33: work to build Fetch response body streams on top ...
4 years, 7 months ago (2016-05-19 07:14:57 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1993033003/diff/20001/third_party/WebKit/Source/core/streams/README.md File third_party/WebKit/Source/core/streams/README.md (right): https://codereview.chromium.org/1993033003/diff/20001/third_party/WebKit/Source/core/streams/README.md#newcode33 third_party/WebKit/Source/core/streams/README.md:33: work to build Fetch response body streams on top ...
4 years, 7 months ago (2016-05-19 07:55:08 UTC) #5
domenic
lgtm https://codereview.chromium.org/1993033003/diff/60001/third_party/WebKit/Source/core/streams/ReadableByteStream.idl File third_party/WebKit/Source/core/streams/ReadableByteStream.idl (right): https://codereview.chromium.org/1993033003/diff/60001/third_party/WebKit/Source/core/streams/ReadableByteStream.idl#newcode7 third_party/WebKit/Source/core/streams/ReadableByteStream.idl:7: // This interface is deprecated. Should we file ...
4 years, 7 months ago (2016-05-19 18:49:25 UTC) #7
yhirano
https://codereview.chromium.org/1993033003/diff/60001/third_party/WebKit/Source/core/streams/ReadableByteStream.idl File third_party/WebKit/Source/core/streams/ReadableByteStream.idl (right): https://codereview.chromium.org/1993033003/diff/60001/third_party/WebKit/Source/core/streams/ReadableByteStream.idl#newcode7 third_party/WebKit/Source/core/streams/ReadableByteStream.idl:7: // This interface is deprecated. On 2016/05/19 18:49:25, domenic ...
4 years, 7 months ago (2016-05-20 03:41:30 UTC) #8
yhirano
We have three LGTMs on the thread!
4 years, 7 months ago (2016-05-20 05:43:40 UTC) #9
kinuko
On 2016/05/20 05:43:40, yhirano wrote: > We have three LGTMs on the thread! \o/
4 years, 7 months ago (2016-05-20 05:45:37 UTC) #10
yhirano
+tkent@ for RuntimeEnabledFeatures.in and webexposed layout tests. +dpranke@ for build/ and build_overrides/.
4 years, 7 months ago (2016-05-20 05:46:54 UTC) #13
tkent
lgtm
4 years, 7 months ago (2016-05-20 05:51:09 UTC) #14
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-20 19:37:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993033003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993033003/100001
4 years, 7 months ago (2016-05-20 23:40:12 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-21 01:34:31 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 01:36:16 UTC) #22
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/e0cb6a355deab56251cea1ac5b2bcc4b605c76e2
Cr-Commit-Position: refs/heads/master@{#395223}

Powered by Google App Engine
This is Rietveld 408576698