Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993033002: Add ldrex and strex instructions to ARM assembler/disassmbler (Closed)

Created:
4 years, 7 months ago by binji
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ldrex and strex instructions to ARM assembler/disassmbler R=jarin@chromium.org,bmeurer@chromium.org Committed: https://crrev.com/4d0ea36c0de5e39db1d0d5bbcf3f22022b59d26b Cr-Commit-Position: refs/heads/master@{#36380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1 line) Patch
M src/arm/assembler-arm.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +39 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
4 years, 7 months ago (2016-05-18 22:23:37 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-19 19:05:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993033002/1
4 years, 7 months ago (2016-05-19 19:09:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 19:11:19 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:13:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d0ea36c0de5e39db1d0d5bbcf3f22022b59d26b
Cr-Commit-Position: refs/heads/master@{#36380}

Powered by Google App Engine
This is Rietveld 408576698