Better boolean conversion tests.

Better boolean conversion tests.

- Same errors as VM & Dartium

  - Failed assertion: boolean expression must not be null
  - type 'int' is not a subtype of type 'bool' in boolean expression

- All boolean conversion contexts use the same logic
- No false positives from combining null and as-bool checks in other contexts

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/016b5f2240c0e448fef87179a86e55ff79092115

[sra1, 2016-05-19 02:12:10]

Description was changed from

==========
Better boolean conversion tests.

- All boolean conversion contexts use the same logic
- No false positives
==========

to

==========
Better boolean conversion tests.

- Same errors as VM & Dartium
- All boolean conversion contexts use the same logic
- No false positives
==========

[sra1, 2016-05-19 02:12:10]

sra@google.com changed reviewers:
+ jmesserly@google.com

[sra1, 2016-05-19 03:10:43]

Patchset #1 (id:1) has been deleted

[sra1, 2016-05-19 03:18:07]

Patchset #1 (id:20001) has been deleted

[sra1, 2016-05-19 03:21:03]

Description was changed from

==========
Better boolean conversion tests.

- Same errors as VM & Dartium
- All boolean conversion contexts use the same logic
- No false positives
==========

to

==========
Better boolean conversion tests.

- Same errors as VM & Dartium

  - Failed assertion: boolean expression must not be null
  - type 'int' is not a subtype of type 'bool' in boolean expression

- All boolean conversion contexts use the same logic
- No false positives from combining null and as-bool checks in other contexts
==========

[Jennifer Messerly, 2016-05-19 17:45:38]

lgtm

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (left):

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:484: // TODO(jmesserly): fuse this with
notNull check.
Why remove this TODO? We still want to be smarter with numeric checks, right?
Rather than emit `notNull(asInt(`

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:4248: // can't set the isSynthetic
attribute.
FYI -- we can send a patch to Analyzer if we need a tweak to how isSynthetic
works. That's always an option.

(But definitely good to work around it first from DDC side first, as patches to
Analyzer take longer to propagate)

[sra1, 2016-05-19 18:57:56]

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (left):

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:484: // TODO(jmesserly): fuse this with
notNull check.
On 2016/05/19 17:45:38, John Messerly wrote:
> Why remove this TODO? We still want to be smarter with numeric checks, right?
> Rather than emit `notNull(asInt(`

I'll add it back.

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1993023003/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:4248: // can't set the isSynthetic
attribute.
On 2016/05/19 17:45:38, John Messerly wrote:
> FYI -- we can send a patch to Analyzer if we need a tweak to how isSynthetic
> works. That's always an option.
> 
> (But definitely good to work around it first from DDC side first, as patches
to
> Analyzer take longer to propagate)

Acknowledged.

[sra1, 2016-05-19 19:05:12]

Description was changed from

==========
Better boolean conversion tests.

- Same errors as VM & Dartium

  - Failed assertion: boolean expression must not be null
  - type 'int' is not a subtype of type 'bool' in boolean expression

- All boolean conversion contexts use the same logic
- No false positives from combining null and as-bool checks in other contexts
==========

to

==========
Better boolean conversion tests.

- Same errors as VM & Dartium

  - Failed assertion: boolean expression must not be null
  - type 'int' is not a subtype of type 'bool' in boolean expression

- All boolean conversion contexts use the same logic
- No false positives from combining null and as-bool checks in other contexts

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/016b5f2240c0e448fef87179a86e...
==========

[sra1, 2016-05-19 19:05:13]

Committed patchset #1 (id:40001) manually as
016b5f2240c0e448fef87179a86e55ff79092115 (presubmit successful).