[Media Router WebUI] Disable search by default.

chrome/browser/resources/media_router/media_router_data.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Any strings used here will already be localized. Values such as
 // CastMode.type or IDs will be defined elsewhere and determined later.
 
 cr.exportPath('media_router');
 
 /**
@@ skipping 48 matching lines @@
  */
 media_router.MediaRouterView = {
   CAST_MODE_LIST: 'cast-mode-list',
   FILTER: 'filter',
   ISSUE: 'issue',
   ROUTE_DETAILS: 'route-details',
   SINK_LIST: 'sink-list',
 };
 
 /**
+ * The minimum number of sinks to have to enable the search input strictly for
+ * filtering (i.e. the Media Router doesn't support search so the search input
+ * only filters existing sinks).
+ * @const {number}
+ */
+media_router.MINIMUM_SINKS_FOR_SEARCH = 20;

[amp, 2016/05/18 22:25:25]

I think even at 10 it would useful.

At 20 I would doubt this would show up for any non-cloud user. (but maybe that's
what we are going for?)

[btolsch, 2016/05/18 22:39:33]

My understanding from previous comments was even when the list is long enough to
scroll, it's faster to scroll than type the sink name.  So from my perspective
we are effectively deemphasizing filtering and focusing more on search.

I don't feel strongly about what we make this number though.

+
+/**
  * This corresponds to the C++ MediaSink IconType.
  * @enum {number}
  */
 media_router.SinkIconType = {
   CAST: 0,
   CAST_AUDIO: 1,
   CAST_AUDIO_GROUP: 2,
   GENERIC: 3,
   HANGOUT: 4,
 };
@@ skipping 170 matching lines @@
 
   return {
     AUTO_CAST_MODE: AUTO_CAST_MODE,
     CastMode: CastMode,
     Issue: Issue,
     Route: Route,
     Sink: Sink,
     TabInfo: TabInfo,
   };
 });