Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: runtime/vm/intermediate_language.h

Issue 1992963002: Enable optimizer pipeline for DBC. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index a7f3d7f8c4c6f3006486a53c33cf2fe8b52411a3..931de101a191130df7e1f4d9641b4c6102a4f85e 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -8188,6 +8188,30 @@ class Environment : public ZoneAllocated {
// from the copy.
Environment* DeepCopy(Zone* zone, intptr_t length) const;
+#if defined(TARGET_ARCH_DBC)
+ // Return/ReturnTOS instruction drops incoming arguments so
+ // we have to drop outgoing arguments from the innermost environment.
+ // On all other architectures caller drops outgoing arguments itself
+ // hence the difference.
+ // Note: this method can only be used at the code generation stage because
+ // it mutates environment in unsafe way (e.g. does not update def-use
+ // chains).
+ void DropArguments(intptr_t argc) {
Florian Schneider 2016/05/19 13:21:40 Maybe put only a declaration here, and put the def
Vyacheslav Egorov (Google) 2016/05/19 15:19:40 Done.
+#if defined(DEBUG)
+ // Check that we are in the backend - register allocation has been run.
+ ASSERT(locations_ != NULL);
+
+ // Check that we are only dropping PushArgument instructions from the
+ // environment.
+ ASSERT(argc <= values_.length());
+ for (intptr_t i = 0; i < argc; i++) {
+ ASSERT(values_[values_.length() - i - 1]->definition()->IsPushArgument());
+ }
+#endif
+ values_.TruncateTo(values_.length() - argc);
+ }
+#endif
+
private:
friend class ShallowIterator;

Powered by Google App Engine
This is Rietveld 408576698