Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: correct a typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/quic/bidirectional_stream_quic_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 348a94e0264866ea56e05ca265898c1b7ec0500a..8ee9657a00eee49067ef2a66982cab8074913b82 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -743,7 +743,7 @@ class TestBidirectionalDelegate : public BidirectionalStreamImpl::Delegate {
const SpdyHeaderBlock& response_headers() const { return response_headers_; }
private:
- void OnStreamReady() override {}
+ void OnStreamReady(bool request_headers_sent) override {}
void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override {
response_headers_ = response_headers;
loop_.Quit();
@@ -1633,7 +1633,8 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
bidi_request_info.priority = LOWEST;
TestBidirectionalDelegate delegate;
- stream_impl->Start(&bidi_request_info, BoundNetLog(), false, &delegate,
+ stream_impl->Start(&bidi_request_info, BoundNetLog(),
+ /*send_request_headers_automatically=*/true, &delegate,
nullptr);
delegate.WaitUntilDone();
@@ -1759,7 +1760,8 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
bidi_request_info.priority = LOWEST;
TestBidirectionalDelegate delegate;
- stream_impl->Start(&bidi_request_info, BoundNetLog(), false, &delegate,
+ stream_impl->Start(&bidi_request_info, BoundNetLog(),
+ /*send_request_headers_automatically=*/true, &delegate,
nullptr);
delegate.WaitUntilDone();
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/quic/bidirectional_stream_quic_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698