components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java - Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: correct a typo Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

index 1c4140cbcdbc4e266121b385596e21bd8f7c73c1..ab530b6e8610abbe4bb352dab3d46521bf11f42b 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

@@ -149,11 +149,13 @@ class CronetUrlRequestContext extends CronetEngine {

@Override

BidirectionalStream createBidirectionalStream(String url, BidirectionalStream.Callback callback,

Executor executor, String httpMethod, List<Map.Entry<String, String>> requestHeaders,

- @BidirectionalStream.Builder.StreamPriority int priority, boolean disableAutoFlush) {

+ @BidirectionalStream.Builder.StreamPriority int priority, boolean disableAutoFlush,

+ boolean delayRequestHeadersUntilFirstFlush) {

synchronized (mLock) {

checkHaveAdapter();

return new CronetBidirectionalStream(this, url, priority, callback, executor,

- httpMethod, requestHeaders, disableAutoFlush);

+ httpMethod, requestHeaders, disableAutoFlush,

+ delayRequestHeadersUntilFirstFlush);

}