Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: net/quic/bidirectional_stream_quic_impl.h

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/bidirectional_stream_quic_impl.h
diff --git a/net/quic/bidirectional_stream_quic_impl.h b/net/quic/bidirectional_stream_quic_impl.h
index e3ff775d8e4c71c52a1bf1bf537c28e497e88783..4ab004aca5a8a84a686a9092e274b69c0668c568 100644
--- a/net/quic/bidirectional_stream_quic_impl.h
+++ b/net/quic/bidirectional_stream_quic_impl.h
@@ -39,7 +39,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
// BidirectionalStreamImpl implementation:
void Start(const BidirectionalStreamRequestInfo* request_info,
const BoundNetLog& net_log,
- bool disable_auto_flush,
+ bool delay_headers_until_next_send_data,
BidirectionalStreamImpl::Delegate* delegate,
std::unique_ptr<base::Timer> timer) override;
int ReadData(IOBuffer* buffer, int buffer_len) override;
@@ -111,7 +111,9 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
// Indicates whether initial headers have been received.
bool has_received_headers_;
- bool disable_auto_flush_;
+ // Whether to delay sending request headers until next SendData/SendvData,
+ // so header frame can be coalesced with data frame in the same packet.
+ bool delay_headers_until_next_send_data_;
base::WeakPtrFactory<BidirectionalStreamQuicImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698