Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: net/http/bidirectional_stream.cc

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/bidirectional_stream.cc
diff --git a/net/http/bidirectional_stream.cc b/net/http/bidirectional_stream.cc
index 8b83c1e93515f06efaa4db3b5aaca903b35ec1ca..778b88e376dce5dd03b430a400402609772c11f8 100644
--- a/net/http/bidirectional_stream.cc
+++ b/net/http/bidirectional_stream.cc
@@ -66,25 +66,25 @@ BidirectionalStream::Delegate::~Delegate() {}
BidirectionalStream::BidirectionalStream(
std::unique_ptr<BidirectionalStreamRequestInfo> request_info,
HttpNetworkSession* session,
- bool disable_auto_flush,
+ bool delay_headers_until_next_send_data,
Delegate* delegate)
: BidirectionalStream(std::move(request_info),
session,
- disable_auto_flush,
+ delay_headers_until_next_send_data,
delegate,
base::WrapUnique(new base::Timer(false, false))) {}
BidirectionalStream::BidirectionalStream(
std::unique_ptr<BidirectionalStreamRequestInfo> request_info,
HttpNetworkSession* session,
- bool disable_auto_flush,
+ bool delay_headers_until_next_send_data,
Delegate* delegate,
std::unique_ptr<base::Timer> timer)
: request_info_(std::move(request_info)),
net_log_(BoundNetLog::Make(session->net_log(),
NetLog::SOURCE_BIDIRECTIONAL_STREAM)),
session_(session),
- disable_auto_flush_(disable_auto_flush),
+ delay_headers_until_next_send_data_(delay_headers_until_next_send_data),
delegate_(delegate),
timer_(std::move(timer)) {
DCHECK(delegate_);
@@ -278,7 +278,8 @@ void BidirectionalStream::OnBidirectionalStreamImplReady(
stream_request_.reset();
stream_impl_.reset(stream);
- stream_impl_->Start(request_info_.get(), net_log_, disable_auto_flush_, this,
+ stream_impl_->Start(request_info_.get(), net_log_,
+ delay_headers_until_next_send_data_, this,
std::move(timer_));
}

Powered by Google App Engine
This is Rietveld 408576698