Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Andrei's comment and self review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index 9dbcc5a091559ff6524d45d7cb8349748f9c3ef6..a4367174edcac3e163e7729fd94cc667dcdc5b22 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -711,12 +711,16 @@ public abstract class CronetEngine {
* {@link BidirectionalStream.Builder#STREAM_PRIORITY_IDLE STREAM_PRIORITY_*}
* values.
* @param disableAutoFlush whether auto flush should be disabled
+ * @param delayHeadersUntilNextFlush whether to delay sending request
+ * headers until next flush(), and try to combine them with the next
mef 2016/06/01 21:33:20 I wonder whether it should be 'delayHeadersUntilFi
xunjieli 2016/06/01 22:27:16 Done.
+ * data frame.
* @return a new stream.
*/
abstract BidirectionalStream createBidirectionalStream(String url,
BidirectionalStream.Callback callback, Executor executor, String httpMethod,
List<Map.Entry<String, String>> requestHeaders,
- @BidirectionalStream.Builder.StreamPriority int priority, boolean disableAutoFlush);
+ @BidirectionalStream.Builder.StreamPriority int priority, boolean disableAutoFlush,
+ boolean delayHeadersUntilNextFlush);
/**
* @return {@code true} if the engine is enabled.

Powered by Google App Engine
This is Rietveld 408576698