third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp - Issue 1992933002: Introduce WorkletGlobalScopeProxy interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 1992933002: Introduce WorkletGlobalScopeProxy interface. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h ('k') | third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

index a6ae1745821100f6b4179715a1c2ed34d4a47bea..ec17dfd1fbaefe5e7e356af6ba51af9db51e6081 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

@@ -32,7 +32,7 @@

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/V8ScriptRunner.h"

-#include "core/workers/WorkerThread.h"

+#include "core/workers/WorkerOrWorkletThread.h"

#include <v8.h>

namespace blink {

@@ -48,7 +48,7 @@ WorkerThreadDebugger* WorkerThreadDebugger::from(v8::Isolate* isolate)

return static_cast<WorkerThreadDebugger*>(data->threadDebugger());

}

-WorkerThreadDebugger::WorkerThreadDebugger(WorkerThread* workerThread, v8::Isolate* isolate)

+WorkerThreadDebugger::WorkerThreadDebugger(WorkerOrWorkletThread* workerThread, v8::Isolate* isolate)

: ThreadDebugger(isolate)

, m_workerThread(workerThread)

{

@@ -60,7 +60,7 @@ WorkerThreadDebugger::~WorkerThreadDebugger()

void WorkerThreadDebugger::contextCreated(v8::Local<v8::Context> context)

{

- debugger()->contextCreated(V8ContextInfo(context, workerContextGroupId, true, m_workerThread->workerGlobalScope()->url().getString(), "", "", false));

+ debugger()->contextCreated(V8ContextInfo(context, workerContextGroupId, true, m_workerThread->globalScope()->url().getString(), "", "", false));

}

void WorkerThreadDebugger::contextWillBeDestroyed(v8::Local<v8::Context> context)

@@ -92,7 +92,7 @@ bool WorkerThreadDebugger::callingContextCanAccessContext(v8::Local<v8::Context>

int WorkerThreadDebugger::ensureDefaultContextInGroup(int contextGroupId)

{

ASSERT(contextGroupId == workerContextGroupId);

- ScriptState* scriptState = m_workerThread->workerGlobalScope()->scriptController()->getScriptState();

+ ScriptState* scriptState = m_workerThread->globalScope()->scriptController()->getScriptState();

if (!scriptState)

return 0;

v8::HandleScope scopes(scriptState->isolate());