Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issue 1992913005: [turbofan] Stage escape analysis optimization. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Stage escape analysis optimization. This stages escape analysis by implying --turbo-escape by the --turbo flag. It broadens the exposure of the optimization in question. R=jarin@chromium.org BUG=v8:4586, v8:5267 Committed: https://crrev.com/62688795ab1dc2d9594131459b019a19195448ad Cr-Commit-Position: refs/heads/master@{#40859}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Patch Set 6 : Fix one test. #

Patch Set 7 : Mark test as failing. #

Patch Set 8 : Rebased. #

Patch Set 9 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 54 (42 generated)
Michael Starzinger
Planning to land this on Monday if ClusterFuzz doesn't find any issues by then.
4 years, 7 months ago (2016-05-19 15:37:08 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-19 19:03:57 UTC) #2
Michael Starzinger
PTAL. Did I say "on Monday"? I of course meant to say "in 4 months".
4 years, 2 months ago (2016-09-29 12:57:06 UTC) #21
Michael Hablich
On 2016/09/29 12:57:06, Michael Starzinger wrote: > PTAL. Did I say "on Monday"? I of ...
4 years, 2 months ago (2016-09-29 13:59:28 UTC) #24
Michael Starzinger
On 2016/09/29 13:59:28, Hablich wrote: > On 2016/09/29 12:57:06, Michael Starzinger wrote: > > PTAL. ...
4 years, 2 months ago (2016-09-29 14:02:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1992913005/120001
4 years, 2 months ago (2016-10-17 08:34:32 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10906)
4 years, 2 months ago (2016-10-17 08:36:42 UTC) #31
Benedikt Meurer
LGTM!
4 years, 2 months ago (2016-10-17 09:27:35 UTC) #32
Michael Starzinger
+Tobias: FYI.
4 years, 1 month ago (2016-11-09 12:14:48 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1992913005/160001
4 years, 1 month ago (2016-11-09 12:50:06 UTC) #50
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 1 month ago (2016-11-09 12:52:10 UTC) #52
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:27:27 UTC) #54
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/62688795ab1dc2d9594131459b019a19195448ad
Cr-Commit-Position: refs/heads/master@{#40859}

Powered by Google App Engine
This is Rietveld 408576698