Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1992903002: Revert of chromeos, GN: make it possible to build many unittests. (Closed)

Created:
4 years, 7 months ago by stevenjb
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, dshwang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos, GN: make it possible to build many unittests. (patchset #1 id:1 of https://codereview.chromium.org/1965183003/ ) Reason for revert: This breaks GN: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20%28dbg%29/builds/20653 Error: ERROR Unresolved dependencies. //:both_gn_and_gyp(//build/toolchain/cros:clang_target) needs //extensions/shell:app_shell(//build/toolchain/cros:clang_target) Original issue's description: > chromeos, GN: make it possible to build many unittests. > > My main target is to build angle_deqp_tests to ensure GL drivers in ChromeOS sane. > > Committed: https://crrev.com/6e7e9c5d2380362959bb2f5721d1fae4f697e530 > Cr-Commit-Position: refs/heads/master@{#394434} TBR=dpranke@chromium.org,dongseong.hwang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f Cr-Commit-Position: refs/heads/master@{#394472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M BUILD.gn View 6 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
stevenjb
Created Revert of chromeos, GN: make it possible to build many unittests.
4 years, 7 months ago (2016-05-18 18:14:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992903002/1
4 years, 7 months ago (2016-05-18 18:15:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 18:15:44 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 18:17:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f
Cr-Commit-Position: refs/heads/master@{#394472}

Powered by Google App Engine
This is Rietveld 408576698