Fixes bugs wrt to painting window header

Fixes bugs wrt to painting window header

- Fixes bug where we paint the maximized task manager window title white (a relic from when the task manager had a black header background when maximized)
- Fixes painting of the border highlight. There are bugs in painting the border highlight for both browser and non-browser windows.
- Split up HeaderPainter::PainterBorder() to HeaderPainter::PaintHighlightForRestoredBrowserWindow() and HeaderPainter::PaintHighlightForInactiveRestoredWindow() in preparation for refactor in https://codereview.chromium.org/189463013/

BUG=352042
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257201

[pkotwicz, 2014-03-13 23:20:49]

James, PTAL

The bugs wrt to the header highlights are hard to without a magnifier.

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter.cc
File ash/frame/header_painter.cc (left):

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter...
ash/frame/header_painter.cc:455: top_right_height);
The y coordinate should be 0

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter.cc
File ash/frame/header_painter.cc (right):

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter...
ash/frame/header_painter.cc:474: 
The left and right images are flush with the top header and the top and bottom
images are tiled between the left and right images.

Maybe we can draw the highlight programmatically, but it's not on top of my
priority list because the designers are so busy

[James Cook, 2014-03-14 00:02:21]

LGTM with nit

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter.cc
File ash/frame/header_painter.cc (right):

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter...
ash/frame/header_painter.cc:45: const SkColor
kNonMaximizedBrowserWindowTitleTextColor =
Would this be clearer as kRestoredBrowserWindowTitleTextColor?  Or is there an
important non-maximized-non-restored case?

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter...
ash/frame/header_painter.cc:314: if (!frame_->IsMaximized() &&
!frame_->IsFullscreen()) {
optional nit: Maybe early return to emphasize that maximized/fullscreen don't
get highlight?

[pkotwicz, 2014-03-14 14:48:45]

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter.cc
File ash/frame/header_painter.cc (right):

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter...
ash/frame/header_painter.cc:45: const SkColor
kNonMaximizedBrowserWindowTitleTextColor =
On 2014/03/14 00:02:22, James Cook wrote:
> Would this be clearer as kRestoredBrowserWindowTitleTextColor?  Or is there an
> important non-maximized-non-restored case?

Done.

https://codereview.chromium.org/199283004/diff/80001/ash/frame/header_painter...
ash/frame/header_painter.cc:314: if (!frame_->IsMaximized() &&
!frame_->IsFullscreen()) {
Keeping it this way makes the diff for the followup refactor CL slightly smaller

[pkotwicz, 2014-03-14 14:48:48]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-03-14 14:48:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/199283004/100001

[commit-bot: I haz the power, 2014-03-14 19:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 19:31:18]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pkotwicz, 2014-03-14 19:35:20]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-03-14 19:37:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/199283004/100001

[commit-bot: I haz the power, 2014-03-14 21:17:01]

Change committed as 257201