Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: components/ntp_snippets/ntp_snippet.h

Issue 1992803002: Use multiple IDs when discarding or merging snippets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippet.h
diff --git a/components/ntp_snippets/ntp_snippet.h b/components/ntp_snippets/ntp_snippet.h
index 20c7fe732711a6b4d48d433529d4eff0c58a62d7..d741d7fa8b202edbca39bea3435332e52b285961 100644
--- a/components/ntp_snippets/ntp_snippet.h
+++ b/components/ntp_snippets/ntp_snippet.h
@@ -57,6 +57,9 @@ class NTPSnippet {
// CreateFromDictionary() the relevant key is 'url'.
// TODO(treib): For now, the ID has to be a valid URL spec, otherwise
// fetching the salient image will fail. See TODO in ntp_snippets_service.cc.
+ // TODO(tschumann): With the new data layout based on the zine backend service
+ // protos, we should distinguish between an ID (should only be used by the JNI
+ // bridge) and a URL (used by snippets internal page etc.).
const std::string& id() const { return id_; }
// Title of the snippet.
« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippets_service.cc » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698