Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1992793002: Fix hashless-hex-color.html quirks-mode test (Closed)

Created:
4 years, 7 months ago by rwlbuis
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh, rune
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, tfarina, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix hashless-hex-color.html quirks-mode test Fix the newly imported hashless-hex-color.html quirks-mode test, I thought this was fixed earlier, but my mistake was assuming hex colors of length 8 were allowed, however upon closer inspection of the spec [1] I missed step 4 initially, so implement that step. BUG=611442 [1] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk Committed: https://crrev.com/2f08cd81c9e45446510cd29862f81480d4df5173 Cr-Commit-Position: refs/heads/master@{#395656}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Patch Set 4 : Rebase #

Patch Set 5 : Patch for landing #

Patch Set 6 : Keep win7 debug entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL.
4 years, 7 months ago (2016-05-23 17:35:11 UTC) #4
Timothy Loh
On 2016/05/23 17:35:11, rwlbuis wrote: > PTAL. lgtm
4 years, 7 months ago (2016-05-24 00:48:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992793002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992793002/100001
4 years, 7 months ago (2016-05-24 16:58:17 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-24 18:57:15 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:58:55 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2f08cd81c9e45446510cd29862f81480d4df5173
Cr-Commit-Position: refs/heads/master@{#395656}

Powered by Google App Engine
This is Rietveld 408576698