[SyzyAsan] Enable Crashpad reporter as a 50/50 experiment.

syzygy/agent/asan/reporters/crashpad_reporter.cc

Index: syzygy/agent/asan/reporters/crashpad_reporter.cc
diff --git a/syzygy/agent/asan/reporters/crashpad_reporter.cc b/syzygy/agent/asan/reporters/crashpad_reporter.cc
index 24cdb9ba19f6ac78e482f06b947ee948f32ef9a1..6a85d5edaf4da46e54741c1a3fca4e14b13439ba 100644
--- a/syzygy/agent/asan/reporters/crashpad_reporter.cc
+++ b/syzygy/agent/asan/reporters/crashpad_reporter.cc
@@ -70,6 +70,8 @@ bool EnsureCrashpadConnected() {
 
 }  // namespace
 
+const char CrashpadReporter::kName[] = "CrashpadReporter";
+
 // static
 std::unique_ptr<CrashpadReporter> CrashpadReporter::Create() {
   // Create a crashpad reporter only if a crashpad instance is running for this
@@ -82,7 +84,7 @@ std::unique_ptr<CrashpadReporter> CrashpadReporter::Create() {
 }
 
 const char* CrashpadReporter::GetName() const {
-  return "CrashpadReporter";
+  return kName;
 }
 
 uint32_t CrashpadReporter::GetFeatures() const {
@@ -167,13 +169,14 @@ CrashpadReporter::CrashpadReporter(crashpad::CrashpadInfo* crashpad_info)
     : crashpad_info_(crashpad_info) {
   crash_keys_.reset(new crashpad::SimpleStringDictionary());
 
-  // Initialize the crashpad info struct.
+  // Initialize the crashpad info struct. Limit indirectly referenced memory to
+  // a maximum of 1MB.

[Sébastien Marchand, 2016/06/02 19:54:18]

What's the actual limit in crash/ ? 

[chrisha, 2016/06/02 20:20:18]

Bigger than this. The other things in the minidump take already around
500-750KB, so setting this to 1MB keeps crash reports under 2MB, which is
similar to their current sizes. I'll make the comment more detailed.

   crashpad_info->set_crashpad_handler_behavior(
       crashpad::TriState::kEnabled);
   crashpad_info->set_system_crash_reporter_forwarding(
       crashpad::TriState::kDisabled);
   crashpad_info->set_gather_indirectly_referenced_memory(
-      crashpad::TriState::kEnabled);
+      crashpad::TriState::kEnabled, 1 * 1024 * 1024);
   crashpad_info->set_simple_annotations(crash_keys_.get());
 }