syzygy/agent/asan/syzyasan_rtl.cc - Issue 1992773002: [SyzyAsan] Enable Crashpad reporter as a 50/50 experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: syzygy/agent/asan/syzyasan_rtl.cc

Issue 1992773002: [SyzyAsan] Enable Crashpad reporter as a 50/50 experiment. (Closed) Base URL: https://github.com/google/syzygy.git@master

Patch Set: Cleanup + unittests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: syzygy/agent/asan/syzyasan_rtl.cc

diff --git a/syzygy/agent/asan/syzyasan_rtl.cc b/syzygy/agent/asan/syzyasan_rtl.cc

index 34fbfa883056aa8229c253fcecab58d6aa795f85..99acaa27fd67f224fcac612dc640923db7bd0724 100644

--- a/syzygy/agent/asan/syzyasan_rtl.cc

+++ b/syzygy/agent/asan/syzyasan_rtl.cc

@@ -41,6 +41,7 @@ static const AsanFeatureName kAsanFeatureNames[] = {

{DEPRECATED_ASAN_FEATURE_ENABLE_CTMALLOC, nullptr},

{ASAN_FEATURE_ENABLE_LARGE_BLOCK_HEAP, "SyzyASANLargeBlockHeap"},

{DEPRECATED_ASAN_FEATURE_ENABLE_KASKO, nullptr},

+ {ASAN_FEATURE_ENABLE_CRASHPAD, "SyzyASANCrashpad"},

Sigurður Ásgeirsson 2016/05/19 20:25:58 you need backend configuration for this as well.

chrisha 2016/05/19 20:31:31 Already landed.

};

// This lock guards against IAT patching on multiple threads concurrently.