[SyzyAsan] Enable Crashpad reporter as a 50/50 experiment.

syzygy/agent/asan/runtime_unittest.cc

 // Copyright 2012 Google Inc. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 270 matching lines @@
   for (const auto& iter : feature_group_frequency) {
     EXPECT_LT(kExpectedCount - kErrorMargin, iter.second);
     EXPECT_GT(kExpectedCount + kErrorMargin, iter.second);
   }
 }
 
 TEST_F(AsanRuntimeTest, PropagateFeatureSet) {
   ASSERT_NO_FATAL_FAILURE(
       asan_runtime_.SetUp(current_command_line_.GetCommandLineString()));
 
-  AsanFeatureSet valid_feature_sets[] = {
-      0,
-      ASAN_FEATURE_ENABLE_LARGE_BLOCK_HEAP,
-      ASAN_FEATURE_ENABLE_PAGE_PROTECTIONS,
-      ASAN_FEATURE_ENABLE_PAGE_PROTECTIONS |
-          ASAN_FEATURE_ENABLE_LARGE_BLOCK_HEAP};
+  for (uint32_t feature_set = 0; feature_set < ASAN_FEATURE_MAX;
+       ++feature_set) {
+    // Skip feature sets that enable deprecated features.
+    if (feature_set & kAsanDeprecatedFeatures)
+      continue;
 
-  size_t number_of_valid_features = 0U;
-  for (size_t i = 0; i < sizeof(kAsanValidFeatures) * 8; ++i) {
-    if ((kAsanDeprecatedFeatures & (1 << i)) != 0U)
-      number_of_valid_features++;
-  }
-
-  EXPECT_EQ(arraysize(valid_feature_sets), 1 << number_of_valid_features);
-
-  for (auto feature_set : valid_feature_sets) {
     asan_runtime_.PropagateFeatureSet(feature_set);
     ::common::AsanParameters expected_params = {};
     ::common::SetDefaultAsanParameters(&expected_params);
     expected_params.enable_large_block_heap =
         ((feature_set & ASAN_FEATURE_ENABLE_LARGE_BLOCK_HEAP) != 0U);
     EXPECT_EQ(0U, ::memcmp(&expected_params, &asan_runtime_.params(),
                            sizeof(::common::AsanParameters)));
     TestBlockHeapManager* test_block_heap_manager =
         static_cast<TestBlockHeapManager*>(asan_runtime_.heap_manager_.get());
     EXPECT_EQ(test_block_heap_manager->enable_page_protections_,
               ((feature_set & ASAN_FEATURE_ENABLE_PAGE_PROTECTIONS) != 0U));
+
+    // Expect the Crashpad bit to always be cleared, as the crash reporter
+    // can't be initialized without a Crashpad server running.
+    EXPECT_EQ(0u,
+        asan_runtime_.GetEnabledFeatureSet() & ASAN_FEATURE_ENABLE_CRASHPAD);
   }
 
   ASSERT_NO_FATAL_FAILURE(asan_runtime_.TearDown());
 }
 
 TEST_F(AsanRuntimeTest, OnErrorSaveEnabledFeatureList) {
   asan_runtime_.params().feature_randomization = true;
   ASSERT_NO_FATAL_FAILURE(
       asan_runtime_.SetUp(current_command_line_.GetCommandLineString()));
 
   // Disable the heap checking as this really slows down the unittests.
   asan_runtime_.params().check_heap_on_failure = false;
   asan_runtime_.SetErrorCallBack(base::Bind(&TestCallback));
   callback_called = false;
   callback_error_info.feature_set = ASAN_FEATURE_MAX;
   AsanErrorInfo bad_access_info = {};
   RtlCaptureContext(&bad_access_info.context);
   AsanFeatureSet expected_feature_set = static_cast<AsanFeatureSet>(
       ASAN_FEATURE_ENABLE_LARGE_BLOCK_HEAP);
   asan_runtime_.PropagateFeatureSet(expected_feature_set);
   asan_runtime_.OnError(&bad_access_info);
   EXPECT_TRUE(callback_called);
   EXPECT_EQ(expected_feature_set, callback_error_info.feature_set);
   ASSERT_NO_FATAL_FAILURE(asan_runtime_.TearDown());
 }
 
 }  // namespace asan
 }  // namespace agent