Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992713002: Make Iterable.generate use ListIterable as base implementation. (Closed)

Created:
4 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Iterable.generate use ListIterable as base implementation. This makes it work the same as a List like the documentation claims. Update documentation of Future.doWhile, and a few other documentation fixes. BUG= http://dartbug.com/26358 BUG= http://dartbug.com/26462 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/5d6e8bcda1c9e90c1240ee144ad08cb078734d62

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reword skip docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -85 lines) Patch
M sdk/lib/async/future.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M sdk/lib/core/iterable.dart View 1 8 chunks +39 lines, -76 lines 0 comments Download
M tests/corelib/iterable_generate_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
4 years, 7 months ago (2016-05-18 07:47:26 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1992713002/diff/1/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/1992713002/diff/1/sdk/lib/core/iterable.dart#newcode425 sdk/lib/core/iterable.dart:425: * Such iterables are allowed to completely ignore ...
4 years, 7 months ago (2016-05-18 09:44:27 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1992713002/diff/1/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/1992713002/diff/1/sdk/lib/core/iterable.dart#newcode425 sdk/lib/core/iterable.dart:425: * Such iterables are allowed to completely ignore the ...
4 years, 7 months ago (2016-05-18 09:54:15 UTC) #4
floitsch
Still LGTM.
4 years, 7 months ago (2016-05-18 09:56:01 UTC) #5
Lasse Reichstein Nielsen
4 years, 7 months ago (2016-05-18 11:52:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5d6e8bcda1c9e90c1240ee144ad08cb078734d62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698