Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1992663002: Vp8Parser: Zero-initialize segment feature data when required (Closed)

Created:
4 years, 7 months ago by Pawel Osciak
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vp8Parser: Zero-initialize segment feature data when required When segmentation is enabled and update_segment_feature_data flag is true, but no actual update value is provided in the stream, the value should be assigned the default "0", instead of what was carried over from previous frame. This applies to both quantizer and loop filter update values. BUG=chrome-os-partner:48886 TEST=Sample video with segment feature data updates,crosvideo.appspot,vdatest Committed: https://crrev.com/c6e09d91e9bdbd5cb4877ce6f5de55a2747dfc20 Cr-Commit-Position: refs/heads/master@{#394616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/filters/vp8_parser.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Pawel Osciak
ptal
4 years, 7 months ago (2016-05-18 03:58:41 UTC) #2
Pawel Osciak
4 years, 7 months ago (2016-05-18 07:53:14 UTC) #4
kcwu
lgtm
4 years, 7 months ago (2016-05-18 08:40:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992663002/1
4 years, 7 months ago (2016-05-18 08:41:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 10:59:50 UTC) #9
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-18 23:50:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992663002/1
4 years, 7 months ago (2016-05-19 00:19:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 00:24:40 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 00:26:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6e09d91e9bdbd5cb4877ce6f5de55a2747dfc20
Cr-Commit-Position: refs/heads/master@{#394616}

Powered by Google App Engine
This is Rietveld 408576698