Task Manager: Preserve selection when rows are added

chrome/browser/ui/task_manager/task_manager_table_model.cc

Index: chrome/browser/ui/task_manager/task_manager_table_model.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc
index 75bf306bc78a4b294667f23dd19e53bb1f52a327..83ae1ffaea0f56058471dc330d5b3425802439cf 100644
--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc
+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc
@@ -583,8 +583,9 @@ void TaskManagerTableModel::OnTaskAdded(TaskId id) {
   // adding |id| to |tasks_| because we want to keep |tasks_| sorted by proc IDs
   // and then by Task IDs.
   tasks_ = observed_task_manager()->GetTaskIdsList();
+  int index = std::find(tasks_.begin(), tasks_.end(), id) - tasks_.begin();

[sky, 2016/05/19 19:08:47]

Move this inside if (tabl_model_observer_) as it's only needed there.

I'm surprised you don't need a static_cast here.

[ncarter (slow), 2016/05/19 22:55:30]

I was surprised too. It turns out we have no warning when assigning from int64
to int32 (crbug.com/167187). difference_type is signed, so there's no
signed/unsigned warning here, which is what usually we hit with size_t's.

I've added a cast anyway.

   if (table_model_observer_)
-    table_model_observer_->OnItemsAdded(RowCount() - 1, 1);
+    table_model_observer_->OnItemsAdded(index, 1);
 }
 
 void TaskManagerTableModel::OnTaskToBeRemoved(TaskId id) {