Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.cc

Issue 1992623002: Task Manager: Preserve selection when rows are added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review fixes. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/task_manager/task_manager_table_model.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc
index 75bf306bc78a4b294667f23dd19e53bb1f52a327..c2f83cbfa3b711baa14b18c7d47d31747dabfa21 100644
--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc
+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc
@@ -583,8 +583,10 @@ void TaskManagerTableModel::OnTaskAdded(TaskId id) {
// adding |id| to |tasks_| because we want to keep |tasks_| sorted by proc IDs
// and then by Task IDs.
tasks_ = observed_task_manager()->GetTaskIdsList();
- if (table_model_observer_)
- table_model_observer_->OnItemsAdded(RowCount() - 1, 1);
+ int index = std::find(tasks_.begin(), tasks_.end(), id) - tasks_.begin();
+ if (table_model_observer_) {
afakhry 2016/05/18 23:12:18 Nit: Please remove the braces.
ncarter (slow) 2016/05/19 00:12:58 Done.
+ table_model_observer_->OnItemsAdded(index, 1);
+ }
}
void TaskManagerTableModel::OnTaskToBeRemoved(TaskId id) {

Powered by Google App Engine
This is Rietveld 408576698