Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.cc

Issue 1992623002: Task Manager: Preserve selection when rows are added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes from sky Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/new_task_manager_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/task_manager/task_manager_table_model.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc
index 75bf306bc78a4b294667f23dd19e53bb1f52a327..075e2e23eee318cb6b38105d38447a5b90cd0bfb 100644
--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc
+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc
@@ -583,8 +583,12 @@ void TaskManagerTableModel::OnTaskAdded(TaskId id) {
// adding |id| to |tasks_| because we want to keep |tasks_| sorted by proc IDs
// and then by Task IDs.
tasks_ = observed_task_manager()->GetTaskIdsList();
- if (table_model_observer_)
- table_model_observer_->OnItemsAdded(RowCount() - 1, 1);
+
+ if (table_model_observer_) {
+ std::vector<TaskId>::difference_type index =
+ std::find(tasks_.begin(), tasks_.end(), id) - tasks_.begin();
+ table_model_observer_->OnItemsAdded(static_cast<int>(index), 1);
+ }
}
void TaskManagerTableModel::OnTaskToBeRemoved(TaskId id) {
« no previous file with comments | « no previous file | chrome/browser/ui/views/new_task_manager_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698