Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1992583002: media: Fix gn deps on media/gpu/* targets (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/gpu/* targets Add more missing dependencies for Windows builds. BUG=599578 TEST=gn check //media/gpu/* is clean on Windows Committed: https://crrev.com/6ff5345b15ad151adf2b417d45f0ec4b57fcacf5 Cr-Commit-Position: refs/heads/master@{#394901}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M media/gpu/BUILD.gn View 3 chunks +9 lines, -7 lines 1 comment Download
M media/gpu/ipc/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jrummell
PTAL. More deps for Windows builds. https://codereview.chromium.org/1992583002/diff/1/media/gpu/BUILD.gn File media/gpu/BUILD.gn (right): https://codereview.chromium.org/1992583002/diff/1/media/gpu/BUILD.gn#newcode332 media/gpu/BUILD.gn:332: deps += [ ...
4 years, 7 months ago (2016-05-18 00:03:39 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-19 20:25:01 UTC) #3
jrummell
+dcheng@ for OWNERS review of IPC/BUILD.gn. No IPC changes, but the IPC directory has a ...
4 years, 7 months ago (2016-05-19 20:28:35 UTC) #5
dcheng
lgtm
4 years, 7 months ago (2016-05-19 20:37:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992583002/1
4 years, 7 months ago (2016-05-19 20:40:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 23:21:40 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:23:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ff5345b15ad151adf2b417d45f0ec4b57fcacf5
Cr-Commit-Position: refs/heads/master@{#394901}

Powered by Google App Engine
This is Rietveld 408576698