Source/platform/scroll/ScrollableArea.h - Issue 199253002: Made PinchViewport a ScrollableArea

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollableArea.h

Issue 199253002: Made PinchViewport a ScrollableArea (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/ScrollableArea.h

diff --git a/Source/platform/scroll/ScrollableArea.h b/Source/platform/scroll/ScrollableArea.h

index c73655a9073d2a022e7e07b449581b482b39bb00..16f5aab879003561ede0e6e28177d3c0d4a8c603 100644

--- a/Source/platform/scroll/ScrollableArea.h

+++ b/Source/platform/scroll/ScrollableArea.h

@@ -114,6 +114,7 @@ public:

const IntPoint& scrollOrigin() const { return m_scrollOrigin; }

bool scrollOriginChanged() const { return m_scrollOriginChanged; }

+ // TODO(bokan): Meaningless name, rename to isActiveFocus

leviw_travelin_and_unemployed 2014/03/26 16:44:38 Generally we use "FIXME" in Blink instead of TODO.

bokan 2014/03/26 19:56:45 Fixed.

virtual bool isActive() const = 0;

virtual int scrollSize(ScrollbarOrientation) const = 0;

virtual void invalidateScrollbar(Scrollbar*, const IntRect&);

@@ -252,7 +253,7 @@ private:

virtual void setScrollOffset(const IntPoint&) = 0;

virtual int lineStep(ScrollbarOrientation) const;

- virtual int pageStep(ScrollbarOrientation) const = 0;

+ virtual int pageStep(ScrollbarOrientation) const;

virtual int documentStep(ScrollbarOrientation) const;

virtual float pixelStep(ScrollbarOrientation) const;

« no previous file with comments | « Source/platform/scroll/ScrollView.cpp ('k') | Source/platform/scroll/ScrollableArea.cpp » ('j') | no next file with comments »