Source/platform/graphics/GraphicsLayer.cpp - Issue 199253002: Made PinchViewport a ScrollableArea

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/GraphicsLayer.cpp

Issue 199253002: Made PinchViewport a ScrollableArea (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/GraphicsLayer.cpp

diff --git a/Source/platform/graphics/GraphicsLayer.cpp b/Source/platform/graphics/GraphicsLayer.cpp

index 310f49aa6fdae87b1f5245f47aba0d33c7c9498d..26de763f247efa2326063a0c033bda30e885192e 100644

--- a/Source/platform/graphics/GraphicsLayer.cpp

+++ b/Source/platform/graphics/GraphicsLayer.cpp

@@ -1182,6 +1182,8 @@ void GraphicsLayer::setScrollableArea(ScrollableArea* scrollableArea, bool isMai

// Main frame scrolling may involve pinch zoom and gets routed through

// WebViewImpl explicitly rather than via GraphicsLayer::didScroll.

+ // TODO(bokan): With pinch virtual viewport the special case will no

+ // longer be needed, remove once old-style pinch is gone.

if (isMainFrame)

m_layer->layer()->setScrollClient(0);

else