Made PinchViewport a ScrollableArea

Source/platform/graphics/GraphicsLayer.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1164 matching lines @@
 
 void GraphicsLayer::setScrollableArea(ScrollableArea* scrollableArea, bool isMainFrame)
 {
     if (m_scrollableArea == scrollableArea)
         return;
 
     m_scrollableArea = scrollableArea;
 
     // Main frame scrolling may involve pinch zoom and gets routed through
     // WebViewImpl explicitly rather than via GraphicsLayer::didScroll.
+    // TODO(bokan): With pinch virtual viewport the special case will no

[aelias_OOO_until_Jul13, 2014/03/24 21:47:24]

Could you make this conditional on the pinchVirtualViewport flag being false
instead?

[bokan, 2014/03/24 23:36:30]

The isMainFrame argument is conditional on that flag when this method is
called in ScrollingCoordinator. Did you want me to move that condition
into here?

[aelias_OOO_until_Jul13, 2014/03/25 00:05:48]

Yes, I think that would make more sense.  Since it's still the main frame, the
current implementation is lying to this method.

[bokan, 2014/03/25 00:54:42]

It doesn't look like there's any hooks in GraphicsLayer into anything that has
Settings/WebSettings so I don't think I can do this without introducing some
layering violations. I could make this method take the setting's value in
another argument but that feels awkward -- I could change isMainFrame to
scrollsCallGraphicsLayerDidScroll or similar. What's your preference?

[aelias_OOO_until_Jul13, 2014/03/25 01:09:00]

OK, whatever, the TODO is fine then.  No big deal as long as we delete it later.

+    // longer be needed, remove once old-style pinch is gone.
     if (isMainFrame)
         m_layer->layer()->setScrollClient(0);
     else
         m_layer->layer()->setScrollClient(this);
 }
 
 void GraphicsLayer::paint(GraphicsContext& context, const IntRect& clip)
 {
     paintGraphicsLayerContents(context, clip);
 }
@@ skipping 21 matching lines @@
 #ifndef NDEBUG
 void showGraphicsLayerTree(const WebCore::GraphicsLayer* layer)
 {
     if (!layer)
         return;
 
     String output = layer->layerTreeAsText(WebCore::LayerTreeIncludesDebugInfo);
     fprintf(stderr, "%s\n", output.utf8().data());
 }
 #endif