Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1992503002: MD WebUI: Update docs for custom iconsets. (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, asanka, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org, Moe, Devlin, Dan Beam, tsergeant, fukino
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Update docs for custom iconsets. Simplify instructions and point to the Sites page documentation. We originally intended to keep the poly-icon.appspot.com URL in sync with the list of icons, so theoretically we could visit the URL when iron-icon definitions change in order to update our copies of them. However, that's confusing and difficult. And Polymer icons get updated very infrequently, so it's not worth the hassle. BUG=605821 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030 Cr-Commit-Position: refs/heads/master@{#394262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M chrome/browser/resources/md_downloads/icons.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_user_manager/icons.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/icons.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/icons.html View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
michaelpg
PTAL, is this clearer?
4 years, 7 months ago (2016-05-17 21:15:03 UTC) #4
tommycli
LGTM better!
4 years, 7 months ago (2016-05-17 21:17:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992503002/1
4 years, 7 months ago (2016-05-17 21:19:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 23:11:27 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 23:13:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030
Cr-Commit-Position: refs/heads/master@{#394262}

Powered by Google App Engine
This is Rietveld 408576698