Replace XFA_N with value

Replace XFA_N with value

The XFA_N define doesn't add anything over just using the value, replaced. The
static arrays and method have been moved to an anonymous namespace.

Committed: https://pdfium.googlesource.com/pdfium/+/0c268e941972fd808d06033b68e22ec2c6648188

[dsinclair, 2016-05-17 19:48:45]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-17 19:48:45]

PTAL.

[Tom Sepez, 2016-05-17 20:08:30]

https://codereview.chromium.org/1992453002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/1992453002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:253: 19, 19, 19, 3,  9,  19, 19, 19, 19, 19,
19, 19, 2,  19, 19, 19,
How about using 255 instead of 19?  That might make a better sentinel for a
uint8_t.

[dsinclair, 2016-05-17 20:13:28]

https://codereview.chromium.org/1992453002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/1992453002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:253: 19, 19, 19, 3,  9,  19, 19, 19, 19, 19,
19, 19, 2,  19, 19, 19,
On 2016/05/17 20:08:30, Tom Sepez wrote:
> How about using 255 instead of 19?  That might make a better sentinel for a
> uint8_t.

Done.

[Tom Sepez, 2016-05-17 20:40:52]

lgtm

[dsinclair, 2016-05-17 20:41:46]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:41:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992453002/20001

[commit-bot: I haz the power, 2016-05-17 21:04:17]

Description was changed from

==========
Replace XFA_N with value

The XFA_N define doesn't add anything over just using the value, replaced. The
static arrays and method have been moved to an anonymous namespace.
==========

to

==========
Replace XFA_N with value

The XFA_N define doesn't add anything over just using the value, replaced. The
static arrays and method have been moved to an anonymous namespace.

Committed:
https://pdfium.googlesource.com/pdfium/+/0c268e941972fd808d06033b68e22ec2c664...
==========

[commit-bot: I haz the power, 2016-05-17 21:04:18]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0c268e941972fd808d06033b68e22ec2c664...