fix bug graph -- it was only getting the last 1000 entries despite my

fix bug graph -- it was only getting the first 1000 entries despite my asking for 99999.  Sigh.

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/cc3c406c92a8aa9220319da44a13622d6eb65d09

[humper, 2014-03-13 16:04:54]

ptal and try not to weep

[epoger, 2014-03-13 16:18:07]

LGTM if you add a comment

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html
File bug_graphs.html (right):

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html#newcode25
bug_graphs.html:25: function getBugData(callback) {
Please add a comment indicating why this complication is necessary.  Ideally, it
would refer to a bug about this shortcoming in the API.

Perhaps:
// The bug database API may not return all the requested bugs in a single call.
// (data.totalResults will return the total number of bugs that meet the
// request parameters, but data.items may only include a subset.)
// Keep calling back to the API, and appending results to all_items, until
// we get as many results as promised in data.totalResults.

[borenet, 2014-03-13 16:19:35]

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html
File bug_graphs.html (right):

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html#newcode23
bug_graphs.html:23: }
This is empty and looks unused... what's it for?

[borenet, 2014-03-13 16:20:47]

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html
File bug_graphs.html (right):

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html#newcode25
bug_graphs.html:25: function getBugData(callback) {
On 2014/03/13 16:18:07, epoger wrote:
> Please add a comment indicating why this complication is necessary.  Ideally,
it
> would refer to a bug about this shortcoming in the API.
> 
> Perhaps:
> // The bug database API may not return all the requested bugs in a single
call.
> // (data.totalResults will return the total number of bugs that meet the
> // request parameters, but data.items may only include a subset.)
> // Keep calling back to the API, and appending results to all_items, until
> // we get as many results as promised in data.totalResults.

+1

[humper, 2014-03-13 16:51:59]

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html
File bug_graphs.html (right):

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html#newcode23
bug_graphs.html:23: }
On 2014/03/13 16:19:36, borenet wrote:
> This is empty and looks unused... what's it for?

It's for making sure you actually reviewed the code.

https://codereview.chromium.org/199243002/diff/1/bug_graphs.html#newcode25
bug_graphs.html:25: function getBugData(callback) {
On 2014/03/13 16:18:07, epoger wrote:
> Please add a comment indicating why this complication is necessary.  Ideally,
it
> would refer to a bug about this shortcoming in the API.
> 
> Perhaps:
> // The bug database API may not return all the requested bugs in a single
call.
> // (data.totalResults will return the total number of bugs that meet the
> // request parameters, but data.items may only include a subset.)
> // Keep calling back to the API, and appending results to all_items, until
> // we get as many results as promised in data.totalResults.

Done.

[humper, 2014-03-13 16:52:05]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-03-13 16:52:08]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/199243002/20001

[commit-bot: I haz the power, 2014-03-13 16:52:19]

Change committed as cc3c406c92a8aa9220319da44a13622d6eb65d09