Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1992403002: UI strings: expand PgUp and PgDwn to the full words. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@backspace-new-shortcut-bubble
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UI strings: expand PgUp and PgDwn to the full words. Now reads "Page Up" and "Page Down". This is consistent with all of the other key names which use the full word. BUG=613382 Committed: https://crrev.com/5eb3649952f4e37b8759395a145e1e86664ab6f0 Cr-Commit-Position: refs/heads/master@{#395279}

Patch Set 1 #

Patch Set 2 : Avoid patch set dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/strings/ui_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Matt Giuca
Hi Scott, Not sure if these strings actually show up anywhere (they are used in ...
4 years, 7 months ago (2016-05-20 00:12:41 UTC) #2
sky
LGTM
4 years, 7 months ago (2016-05-20 15:52:26 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1983803002 Patch 350001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-23 00:38:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992403002/20001
4 years, 7 months ago (2016-05-23 00:57:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 01:56:55 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 01:57:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5eb3649952f4e37b8759395a145e1e86664ab6f0
Cr-Commit-Position: refs/heads/master@{#395279}

Powered by Google App Engine
This is Rietveld 408576698