content/browser/renderer_host/render_view_host_delegate_view.h - Issue 1992393002: Enable external popup menu in Blimp, part 1/2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_delegate_view.h

Issue 1992393002: Enable external popup menu in Blimp, part 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and update blimp_engine.gn Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_delegate_view.h

diff --git a/content/browser/renderer_host/render_view_host_delegate_view.h b/content/browser/renderer_host/render_view_host_delegate_view.h

index 56bed08ab49a86b08cecfedb8a3b8b8bd9c01b5e..3fdd338b3ea2929857d6b021f9981cacc7f845f5 100644

--- a/content/browser/renderer_host/render_view_host_delegate_view.h

+++ b/content/browser/renderer_host/render_view_host_delegate_view.h

@@ -65,7 +65,7 @@ class CONTENT_EXPORT RenderViewHostDelegateView {

// retrieved by doing a Shift-Tab.

virtual void TakeFocus(bool reverse) {}

-#if defined(OS_MACOSX) || defined(OS_ANDROID)

+#if defined(USE_EXTERNAL_POPUP_MENU)

// Shows a popup menu with the specified items.

// This method should call RenderFrameHost::DidSelectPopupMenuItem[s]() or

// RenderFrameHost::DidCancelPopupMenu() based on the user action.