Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: build/common.gypi

Issue 1992393002: Enable external popup menu in Blimp, part 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and update blimp_engine.gn Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/args/blimp_engine.gn ('k') | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c172ff4798715a655ba7b8fc3aa2a4eb5949ea5d..b7b82c1f0759a98bcd60c9fb81768dee7a554e68 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -70,6 +70,9 @@
# certificate verification, but this configuration is unsupported.
'use_openssl_certs%': 0,
+ # Whether or not we use external popup menu.
+ 'use_external_popup_menu%': 0,
+
# Disable viewport meta tag by default.
'enable_viewport%': 0,
@@ -140,6 +143,11 @@
'use_ozone%': 1,
}],
+ # Mac and Android use external popup menu.
+ ['OS=="mac" or OS=="android"', {
+ 'use_external_popup_menu%': 1,
+ }],
+
['OS=="android"', {
'target_arch%': 'arm',
}, {
@@ -160,6 +168,7 @@
'embedded%': '<(embedded)',
'use_libpci%': '<(use_libpci)',
'use_openssl_certs%': '<(use_openssl_certs)',
+ 'use_external_popup_menu%': '<(use_external_popup_menu)',
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
'enable_wayland_server%': '<(enable_wayland_server)',
@@ -339,6 +348,7 @@
'use_clipboard_aurax11%': '<(use_clipboard_aurax11)',
'embedded%': '<(embedded)',
'use_openssl_certs%': '<(use_openssl_certs)',
+ 'use_external_popup_menu%': '<(use_external_popup_menu)',
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
'enable_wayland_server%': '<(enable_wayland_server)',
@@ -1134,6 +1144,7 @@
'use_cras%': '<(use_cras)',
'use_libpci%': '<(use_libpci)',
'use_openssl_certs%': '<(use_openssl_certs)',
+ 'use_external_popup_menu%': '<(use_external_popup_menu)',
'use_nss_certs%': '<(use_nss_certs)',
'use_udev%': '<(use_udev)',
'os_bsd%': '<(os_bsd)',
@@ -2763,6 +2774,9 @@
['use_udev==1', {
'defines': ['USE_UDEV'],
}],
+ ['use_external_popup_menu==1', {
+ 'defines': ['USE_EXTERNAL_POPUP_MENU'],
+ }],
['fastbuild!=0', {
'xcode_settings': {
'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
« no previous file with comments | « build/args/blimp_engine.gn ('k') | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698