build/config/BUILD.gn - Issue 1992393002: Enable external popup menu in Blimp, part 1/2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1992393002: Enable external popup menu in Blimp, part 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 259c0158003e60e189829f197f0b57ba6024722e..113955b585378df159f8f1540849bff10a8ebe27 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -168,6 +168,9 @@ config("feature_flags") {

if (is_ubsan || is_ubsan_vptr || is_ubsan_security) {

defines += [ "UNDEFINED_SANITIZER" ]

}

+ if (is_android || is_mac || use_external_popup_menu) {

+ defines += [ "USE_EXTERNAL_POPUP_MENU=1" ]

Avi (use Gerrit) 2016/05/27 02:00:00 The Mac hasn't fully switched to GN so you'll need

haibinlu 2016/05/28 01:37:59 Done.

+ }

if (enable_webrtc) {

defines += [ "ENABLE_WEBRTC=1" ]

}