Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Side by Side Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 1992393002: Enable external popup menu in Blimp, part 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_aura.h" 5 #include "content/browser/web_contents/web_contents_view_aura.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1116 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 1127
1128 void WebContentsViewAura::OnWindowVisibilityChanged(aura::Window* window, 1128 void WebContentsViewAura::OnWindowVisibilityChanged(aura::Window* window,
1129 bool visible) { 1129 bool visible) {
1130 // Ignore any visibility changes in the hierarchy below. 1130 // Ignore any visibility changes in the hierarchy below.
1131 if (window != window_.get() && window_->Contains(window)) 1131 if (window != window_.get() && window_->Contains(window))
1132 return; 1132 return;
1133 1133
1134 web_contents_->UpdateWebContentsVisibility(visible); 1134 web_contents_->UpdateWebContentsVisibility(visible);
1135 } 1135 }
1136 1136
1137 #if defined(USE_EXTERNAL_POPUP_MENU)
1138 void WebContentsViewAura::ShowPopupMenu(RenderFrameHost* render_frame_host,
1139 const gfx::Rect& bounds,
1140 int item_height,
1141 double item_font_size,
1142 int selected_item,
1143 const std::vector<MenuItem>& items,
1144 bool right_aligned,
1145 bool allow_multiple_selection) {
1146 LOG(ERROR) << "ShowPopupMenu " << items.size() << " items";
Avi (use Gerrit) 2016/05/27 02:00:00 NOTIMPLEMENTED() << ...
haibinlu 2016/05/28 01:37:59 Done.
1147 }
1148
1149 void WebContentsViewAura::HidePopupMenu() {
1150 LOG(ERROR) << "HidePopupMenu";
1151 }
1152 #endif
1153
1137 } // namespace content 1154 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698