Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1992373002: Simplify ordering of top-level declarations. (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify ordering of top-level declarations. We had some leftover complexity that could be refactored away. This doesn't fix anything yet, but simplifying the foundation may help with recursive generic types. Removes "customEmitDeclaration" too. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/57fbd697f74709cff05de5a0a79a381df55c989d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -62 lines) Patch
M lib/src/compiler/code_generator.dart View 9 chunks +48 lines, -27 lines 0 comments Download
M lib/src/compiler/element_loader.dart View 5 chunks +10 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
4 years, 7 months ago (2016-05-19 22:33:10 UTC) #3
vsm
lgtm
4 years, 7 months ago (2016-05-20 19:25:23 UTC) #4
Jennifer Messerly
4 years, 7 months ago (2016-05-20 19:32:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57fbd697f74709cff05de5a0a79a381df55c989d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698