Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199233002: Moved the ManagedBookmarksPolicyHandler to a shared file. (Closed)

Created:
6 years, 9 months ago by Joao da Silva
Modified:
6 years, 9 months ago
Reviewers:
nyquist, dconnelly
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Visibility:
Public.

Description

Moved the ManagedBookmarksPolicyHandler to a shared file. This change allows reusing that policy handler on iOS too. The strings used by this handler are also included on iOS builds now. BUG=349983 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -157 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/bookmarks/managed_bookmarks_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/configuration_policy_handler_android.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/policy/configuration_policy_handler_android.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/policy/managed_bookmarks_policy_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/policy/managed_bookmarks_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/profile_policy_connector_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +1 line, -1 line 0 comments Download
M components/policy_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Joao da Silva
Please have a look: @Daniel: policy changes @Tommy:: android changes Thanks!
6 years, 9 months ago (2014-03-13 15:47:17 UTC) #1
dconnelly
lgtm
6 years, 9 months ago (2014-03-13 16:05:32 UTC) #2
nyquist
lgtm
6 years, 9 months ago (2014-03-13 16:12:25 UTC) #3
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-13 16:13:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/199233002/1
6 years, 9 months ago (2014-03-13 16:14:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 16:16:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-13 16:16:32 UTC) #7
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-13 17:56:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/199233002/1
6 years, 9 months ago (2014-03-13 18:00:55 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 20:45:32 UTC) #10
Message was sent while issue was closed. 
Change committed as 256922

Powered by Google App Engine
This is Rietveld 408576698