Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1992323002: Disable flaky WebViewContextMenuInteractiveTest test on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 908 matching lines...) Expand 10 before | Expand all | Expand 10 after
919 ASSERT_EQ(20, menu_observer.params().y); 919 ASSERT_EQ(20, menu_observer.params().y);
920 } 920 }
921 921
922 // Tests whether <webview> context menu sees <webview> local coordinates in its 922 // Tests whether <webview> context menu sees <webview> local coordinates in its
923 // RenderViewContextMenu params, when it is subject to CSS transforms. 923 // RenderViewContextMenu params, when it is subject to CSS transforms.
924 // 924 //
925 // This test doesn't makes sense in --use-cross-process-frames-for-guests, since 925 // This test doesn't makes sense in --use-cross-process-frames-for-guests, since
926 // it tests that events forwarded from the embedder are properly transformed, 926 // it tests that events forwarded from the embedder are properly transformed,
927 // and in oopif-mode the events are sent directly to the child process without 927 // and in oopif-mode the events are sent directly to the child process without
928 // the forwarding code path (relying on surface-based hittesting). 928 // the forwarding code path (relying on surface-based hittesting).
929
930 // Flaky on ChromeOS. http://crbug.com/613258
931 #if defined(OS_CHROMEOS)
932 #define MAYBE_ContextMenuParamsAfterCSSTransforms \
933 DISABLED_ContextMenuParamsAfterCSSTransforms
934 #else
935 #define MAYBE_ContextMenuParamsAfterCSSTransforms \
936 ContextMenuParamsAfterCSSTransforms
937 #endif
929 IN_PROC_BROWSER_TEST_F(WebViewContextMenuInteractiveTest, 938 IN_PROC_BROWSER_TEST_F(WebViewContextMenuInteractiveTest,
930 ContextMenuParamsAfterCSSTransforms) { 939 MAYBE_ContextMenuParamsAfterCSSTransforms) {
931 LoadAndLaunchPlatformApp("web_view/context_menus/coordinates_with_transforms", 940 LoadAndLaunchPlatformApp("web_view/context_menus/coordinates_with_transforms",
932 "Launched"); 941 "Launched");
933 942
934 if (!embedder_web_contents_) 943 if (!embedder_web_contents_)
935 embedder_web_contents_ = GetFirstAppWindowWebContents(); 944 embedder_web_contents_ = GetFirstAppWindowWebContents();
936 EXPECT_TRUE(embedder_web_contents()); 945 EXPECT_TRUE(embedder_web_contents());
937 946
938 if (!guest_web_contents_) 947 if (!guest_web_contents_)
939 guest_web_contents_ = GetGuestViewManager()->WaitForSingleGuestCreated(); 948 guest_web_contents_ = GetGuestViewManager()->WaitForSingleGuestCreated();
940 EXPECT_TRUE(guest_web_contents()); 949 EXPECT_TRUE(guest_web_contents());
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 // this time. 1347 // this time.
1339 for (size_t i = 0; i < 4; ++i) 1348 for (size_t i = 0; i < 4; ++i)
1340 SendKeyPressToPlatformApp(ui::VKEY_TAB); 1349 SendKeyPressToPlatformApp(ui::VKEY_TAB);
1341 ExtensionTestMessageListener webview_button_not_focused_listener( 1350 ExtensionTestMessageListener webview_button_not_focused_listener(
1342 "WebViewInteractiveTest.WebViewButtonWasNotFocused", false); 1351 "WebViewInteractiveTest.WebViewButtonWasNotFocused", false);
1343 webview_button_not_focused_listener.set_failure_message( 1352 webview_button_not_focused_listener.set_failure_message(
1344 "WebViewInteractiveTest.WebViewButtonWasFocused"); 1353 "WebViewInteractiveTest.WebViewButtonWasFocused");
1345 SendMessageToEmbedder("verify"); 1354 SendMessageToEmbedder("verify");
1346 EXPECT_TRUE(webview_button_not_focused_listener.WaitUntilSatisfied()); 1355 EXPECT_TRUE(webview_button_not_focused_listener.WaitUntilSatisfied());
1347 } 1356 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698