EME: Add milestone to deprecation message for container-only contentType strings

EME: Add milestone to deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes

Committed: https://crrev.com/ddc14e3fa1385f02b466336dc60d0e1eda450769
Cr-Commit-Position: refs/heads/master@{#394890}

[jrummell, 2016-05-19 19:21:49]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org

[jrummell, 2016-05-19 19:21:49]

PTAL.

[ddorwin, 2016-05-19 19:37:29]

Thanks. I added some suggestions.

Also, can we change the first line to say something like "Add milestone to
deprecation..."?

https://chromiumcodereview.appspot.com/1992313002/diff/1/third_party/WebKit/S...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://chromiumcodereview.appspot.com/1992313002/diff/1/third_party/WebKit/S...
third_party/WebKit/Source/core/frame/Deprecation.cpp:372: return
String::format("contentType strings without codecs will not be supported by
requestMediaKeySystemAccess() in %s. Please specify the desired codec(s) as part
of the contentType.", milestoneString(54));
Most other messages say "will be removed in," which is a little less ambiguous
than "will not be supported in" a specific version.

There are some other changes we might make to be more consistent. For example:
EME requires that contentType strings accepted by requestMediaKeySystemAccess()
include codecs. Non-standard support for contentType strings without codecs will
be removed in %s. Please specify the desired codec(s) as part of the
contentType.

[jrummell, 2016-05-19 19:51:33]

Description was changed from

==========
EME: Update deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes
==========

to

==========
EME: Add milestone to deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes
==========

[jrummell, 2016-05-19 19:52:21]

Updated.

https://chromiumcodereview.appspot.com/1992313002/diff/1/third_party/WebKit/S...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://chromiumcodereview.appspot.com/1992313002/diff/1/third_party/WebKit/S...
third_party/WebKit/Source/core/frame/Deprecation.cpp:372: return
String::format("contentType strings without codecs will not be supported by
requestMediaKeySystemAccess() in %s. Please specify the desired codec(s) as part
of the contentType.", milestoneString(54));
On 2016/05/19 19:37:29, ddorwin wrote:
> Most other messages say "will be removed in," which is a little less ambiguous
> than "will not be supported in" a specific version.
> 
> There are some other changes we might make to be more consistent. For example:
> EME requires that contentType strings accepted by
requestMediaKeySystemAccess()
> include codecs. Non-standard support for contentType strings without codecs
will
> be removed in %s. Please specify the desired codec(s) as part of the
> contentType.

Done.

[ddorwin, 2016-05-19 19:53:07]

lgtm

Thanks!

[jrummell, 2016-05-19 19:54:58]

jrummell@chromium.org changed reviewers:
+ dcheng@chromium.org

[jrummell, 2016-05-19 19:54:59]

+dcheng@ for OWNERS review. A deprecation message change, so just a 1 line
change.

[dcheng, 2016-05-19 20:03:01]

lgtm

[jrummell, 2016-05-19 20:21:10]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-05-19 20:21:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992313002/20001

[commit-bot: I haz the power, 2016-05-19 22:40:05]

Description was changed from

==========
EME: Add milestone to deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes
==========

to

==========
EME: Add milestone to deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes
==========

[commit-bot: I haz the power, 2016-05-19 22:40:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 22:41:46]

Description was changed from

==========
EME: Add milestone to deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes
==========

to

==========
EME: Add milestone to deprecation message for container-only contentType strings

Update the message to indicate that support will be removed in M54.

BUG=605661
TEST=EME layout tests passes

Committed: https://crrev.com/ddc14e3fa1385f02b466336dc60d0e1eda450769
Cr-Commit-Position: refs/heads/master@{#394890}
==========

[commit-bot: I haz the power, 2016-05-19 22:41:47]

Patchset 2 (id:??) landed as
https://crrev.com/ddc14e3fa1385f02b466336dc60d0e1eda450769
Cr-Commit-Position: refs/heads/master@{#394890}