Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 19923004: Remove chromedriver from Win64 official to improve cycle times (Closed)

Created:
7 years, 5 months ago by jschuh
Modified:
7 years, 5 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Remove chromedriver from Win64 official to improve cycle times Also cleaned up a bit, since the exclusion list was getting long. BUG=262193 R=iannucci@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213007

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M build/all.gyp View 1 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jschuh
One more dependency down, and I swapped out the list to the way you wanted ...
7 years, 5 months ago (2013-07-22 22:23:17 UTC) #1
iannucci1
lgtm % nits https://codereview.chromium.org/19923004/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/19923004/diff/1/build/all.gyp#newcode771 build/all.gyp:771: # Removing tests from Win64 to ...
7 years, 5 months ago (2013-07-22 22:31:41 UTC) #2
jschuh
https://codereview.chromium.org/19923004/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/19923004/diff/1/build/all.gyp#newcode771 build/all.gyp:771: # Removing tests from Win64 to speed up cycle ...
7 years, 5 months ago (2013-07-22 23:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/19923004/8001
7 years, 5 months ago (2013-07-22 23:12:34 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-22 23:28:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/19923004/8001
7 years, 5 months ago (2013-07-22 23:55:10 UTC) #6
jschuh
7 years, 5 months ago (2013-07-23 00:26:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r213007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698