Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1992243003: Remove MessageLoop::os_modal_loop_. (Closed)

Created:
4 years, 7 months ago by fdoray
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, ananta
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::os_modal_loop_. This member is always false. BUG= Committed: https://crrev.com/1c8fc4c2731c8a42b36678bdc6be7b45d7541296 Cr-Commit-Position: refs/heads/master@{#395711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -40 lines) Patch
M base/message_loop/message_loop.h View 2 chunks +0 lines, -16 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 2 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
fdoray
Can you review this CL? Thanks.
4 years, 7 months ago (2016-05-19 17:21:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992243003/1
4 years, 7 months ago (2016-05-19 17:22:36 UTC) #4
Lei Zhang
+ananta
4 years, 7 months ago (2016-05-19 17:31:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 18:57:33 UTC) #8
fdoray
ananta@: Can you review this CL? Context: We plan to use MessagePumps in base/task_scheduler/. MessageLoop::current() ...
4 years, 7 months ago (2016-05-24 15:02:47 UTC) #9
ananta
lgtm
4 years, 7 months ago (2016-05-24 19:02:46 UTC) #10
Lei Zhang
rslgtm
4 years, 7 months ago (2016-05-24 19:07:21 UTC) #11
fdoray
On 2016/05/24 19:07:21, Lei Zhang wrote: > rslgtm thestig@: Is that an lgtm?
4 years, 7 months ago (2016-05-24 19:44:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992243003/1
4 years, 7 months ago (2016-05-24 19:45:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/189029)
4 years, 7 months ago (2016-05-24 19:54:02 UTC) #16
Lei Zhang
rs lgtm
4 years, 7 months ago (2016-05-24 20:12:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992243003/1
4 years, 7 months ago (2016-05-24 20:13:02 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 22:29:38 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 22:32:21 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c8fc4c2731c8a42b36678bdc6be7b45d7541296
Cr-Commit-Position: refs/heads/master@{#395711}

Powered by Google App Engine
This is Rietveld 408576698