Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1992203002: Use "application default" audio device as default PulseAudio device (Closed)

Created:
4 years, 7 months ago by Henrik Grunell
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "application default" audio device as default PulseAudio device. This reverts commit 254c78a58a9da3a320c5ce8b1d84c0843fe3b8bc (https://codereview.chromium.org/1711823004) which changed to use the system default. That change causes problems for some use cases. BUG=606163 TBR=tommi@chromium.org (this is a revert) Committed: https://crrev.com/398915beccf80d5e9632b4fa8ea4f61bbc0b4835 Cr-Commit-Position: refs/heads/master@{#394758}

Patch Set 1 #

Patch Set 2 : Merge fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -173 lines) Patch
M media/audio/pulse/pulse_input.h View 2 chunks +1 line, -16 lines 0 comments Download
M media/audio/pulse/pulse_input.cc View 2 chunks +1 line, -28 lines 0 comments Download
M media/audio/pulse/pulse_output.h View 3 chunks +0 lines, -19 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 1 chunk +1 line, -93 lines 0 comments Download
M media/audio/pulse/pulse_util.h View 2 chunks +2 lines, -6 lines 0 comments Download
M media/audio/pulse/pulse_util.cc View 1 7 chunks +49 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Henrik Grunell
4 years, 7 months ago (2016-05-19 11:38:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992203002/1
4 years, 7 months ago (2016-05-19 11:38:57 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/173019) linux_chromium_gn_chromeos_rel on ...
4 years, 7 months ago (2016-05-19 11:55:01 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992203002/20001
4 years, 7 months ago (2016-05-19 12:06:42 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 13:24:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992203002/20001
4 years, 7 months ago (2016-05-19 13:37:58 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 13:42:49 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:44:37 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/398915beccf80d5e9632b4fa8ea4f61bbc0b4835
Cr-Commit-Position: refs/heads/master@{#394758}

Powered by Google App Engine
This is Rietveld 408576698