Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1992153002: Make sure only toStringTag is used for Object.prototype.toString with JSON / Math (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure only toStringTag is used for Object.prototype.toString with JSON / Math BUG= Committed: https://crrev.com/584386a2d9d4bcca8f9958b20c0781021af40c3f Cr-Commit-Position: refs/heads/master@{#36393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/json.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/math.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-05-19 08:49:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992153002/1
4 years, 7 months ago (2016-05-19 08:49:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 09:26:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992153002/1
4 years, 7 months ago (2016-05-19 14:59:13 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-19 14:59:15 UTC) #10
adamk
lgtm
4 years, 7 months ago (2016-05-19 19:20:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992153002/1
4 years, 7 months ago (2016-05-20 07:55:45 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 07:58:12 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 08:00:43 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/584386a2d9d4bcca8f9958b20c0781021af40c3f
Cr-Commit-Position: refs/heads/master@{#36393}

Powered by Google App Engine
This is Rietveld 408576698