Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992133002: Update flatbuffers to HEAD of upstream (Closed)

Created:
4 years, 7 months ago by battre
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, engedy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update flatbuffers to HEAD of upstream BUG=611782 Committed: https://crrev.com/1be614076087f4f0b015cc97de40227b81962c0a Cr-Commit-Position: refs/heads/master@{#395543}

Patch Set 1 #

Patch Set 2 : Bumped version once more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/flatbuffers/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/flatbuffers/README.chromium View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/flatbuffers/flatbuffers.gyp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
battre
Brett, could you please review this CL? Thanks, Dominic
4 years, 7 months ago (2016-05-19 07:15:11 UTC) #2
brettw
lgtm
4 years, 7 months ago (2016-05-23 20:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992133002/20001
4 years, 7 months ago (2016-05-24 06:55:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 08:09:15 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 08:11:16 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1be614076087f4f0b015cc97de40227b81962c0a
Cr-Commit-Position: refs/heads/master@{#395543}

Powered by Google App Engine
This is Rietveld 408576698